[FLINK-25434] Throw an error when BigDecimal precision overflows.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.14.2
• Component/s: Table SQL / Planner, Table SQL / Runtime
• Assignee: Unassigned
• Reporter: Luning Wang
• Created: 23/Dec/21 12:52
• Updated: 23/Dec/21 13:21
• Resolved: 23/Dec/21 13:21

Description

 

Lost a lot of data but no error was thrown.

As the following comment, If the precision overflows, null will be returned.

/**
 If the precision overflows, null will be returned.
 */
public static @Nullable DecimalData fromBigDecimal(BigDecimal bd, int precision, int scale) {
    bd = bd.setScale(scale, RoundingMode.HALF_UP);
    if (bd.precision() > precision) {
        return null;
    }

    long longVal = -1;
    if (precision <= MAX_COMPACT_PRECISION) {
        longVal = bd.movePointRight(scale).longValueExact();
    }
    return new DecimalData(precision, scale, longVal, bd);
} 

Issue Links

• duplicates: FLINK-24420 Casting to a "narrower" type doesn't throw exception but follows Java overflow
• duplicates: FLINK-24847 Decide the overflows behaviour