[FLINK-25119] The name of freeSlots parameter in SlotSharingSlotAllocator#determineParallelism method is named incorrectly.

• Type: Improvement
• Status: Open
• Priority: Not a Priority
• Resolution: Unresolved
• Affects Version/s: 1.13.0, 1.14.0, 1.13.1, 1.13.2, 1.13.3
• Component/s: Runtime / Coordination
• Labels: auto-deprioritized-minor pull-request-available

Language

java

• Assignee: Unassigned
• Reporter: Cassie
• Created: 01/Dec/21 03:20
• Updated: 18/Jul/22 22:38

Description

determineParallism方法中的第二个参数freeSlots，即为在slotpool中空闲的slot，但实际使用时，有的调用方传入的是slotpool中all slot(allocated slot and free slot)，有的调用方传入的是slotpool中free slot，因此参数名直接定义成freeSlots，不够准确，影响对determineParallism逻辑的理解。

 

Issue Links

• links to: GitHub Pull Request #18247