[FLINK-24706] AkkaInvocationHandler silently ignores deserialization errors

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.13.0
• Fix Version/s: 1.14.3, 1.15.0
• Component/s: Runtime / Coordination
• Labels: pull-request-available
• Assignee: Chesnay Schepler
• Reporter: Chesnay Schepler
• Created: 29/Oct/21 12:30
• Updated: 15/Dec/21 01:44
• Resolved: 05/Nov/21 13:42

Description

In AkkaInvocationHandler#invokeRpc we create a new CompletableFuture to return to the caller, and setup a forwarding routine that runs when the response is received via akka.

final CompletableFuture<Object> completableFuture = new CompletableFuture<>();
resultFuture.whenComplete(
        (resultValue, failure) -> {
            if (failure != null) {
                completableFuture.completeExceptionally(
                        resolveTimeoutException(
                                failure, callStackCapture, address, rpcInvocation));
            } else {
                completableFuture.complete(
                        deserializeValueIfNeeded(resultValue, method));
            }
        });

If deserializeValueIfNeeded fails then completableFuture will never be completed, and we exception will not be logged anywhere.

Issue Links

• is related to: FLINK-24550 Can not access job information from a standby jobmanager UI
• links to: GitHub Pull Request #17606