[FLINK-24609] flink-rpc-akka uses wrong Scala version property for parser-combinators

• Type: Technical Debt
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.14.0, 1.15.0
• Fix Version/s: 1.14.3, 1.15.0
• Component/s: Build System
• Labels: pull-request-available
• Assignee: Chesnay Schepler
• Reporter: Chesnay Schepler
• Created: 21/Oct/21 08:54
• Updated: 15/Dec/21 01:44
• Resolved: 05/Nov/21 13:42

Description

dependencyManagement entry:

<dependency>
	<groupId>org.scala-lang.modules</groupId>
	<artifactId>scala-parser-combinators_${scala.binary.version}</artifactId>
	<version>1.1.2</version>
</dependency>

Conceptually this should use ${akka.scala.binary.version}.

Interestingly enough, changing this breaks the build because maven then ignores the entry entirely, only using the existing entry from the root pom. I think there's some bug where if properties are used in artifactIds, then the properties references themselves must match in order to override them. Amazingly, this even fails if you hard-code the scala version.

Adding a direct dependency on parser-combinators does fix the packaging problem, but then we run into dependency convergence errors.
What we can try is overriding scala.binary.version instead; maybe that does the trick...

Issue Links

• links to: GitHub Pull Request #17535