[FLINK-24381] Table API exceptions may leak sensitive configuration values

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.13.0
• Fix Version/s: 1.14.3, 1.15.0
• Component/s: Table SQL / Planner
• Labels: pull-request-available
• Assignee: Luning Wang
• Reporter: Luning Wang
• Created: 27/Sep/21 06:56
• Updated: 15/Dec/21 01:44
• Resolved: 02/Nov/21 11:56

Description

This following is error message. Password is 'bar' and is displayed.

Could we hidden it to password='******' or password='<hidden>' inspired by Apache Kafka source code.

Missing required options are:

hosts 

Unable to create a sink for writing table 'default_catalog.default_database.dws'.

Table options are:

'connector'='elasticsearch7-x'
'index'='foo'
'password'='bar'
	at org.apache.flink.table.factories.FactoryUtil.createTableSink(FactoryUtil.java:208)
	at org.apache.flink.table.planner.delegation.PlannerBase.getTableSink(PlannerBase.scala:369)
	at org.apache.flink.table.planner.delegation.PlannerBase.translateToRel(PlannerBase.scala:221)
	at org.apache.flink.table.planner.delegation.PlannerBase.$anonfun$translate$1(PlannerBase.scala:159

Issue Links

• causes: FLINK-24734 testSecretOption fails due to missing required options
• links to: GitHub Pull Request #17555