[FLINK-23729] sql-client.sh fails on Git Bash for Windows, MinGW & MSYS2

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 1.12.5
• Component/s: Command Line Client
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Derek Moore
• Created: 11/Aug/21 15:23
• Updated: 13/Aug/21 16:51
• Resolved: 12/Aug/21 02:18

Description

sql-client.sh uses manglePath() and manglePathList() from config.sh. These helper functions only recognize "CYGWIN" and not "msys".

Adding awareness of "msys" allows sql-client.sh to mostly work on Windows.

The log4j-cli.properties file location is also incorrectly constructed on Windows machines, but this doesn't fail sql-client.sh from loading.

Issue Links

• links to: GitHub Pull Request #16795