[FLINK-22654] SqlCreateTable toString()/unparse() lose CONSTRAINTS and watermarks - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 1.13.0
Fix Version/s: 1.14.0, 1.13.1
Component/s: Table SQL / Planner
Labels:
- pull-request-available

Description

create a SqlCreateTable using like clause and then toString() or unparse() will lose watermark

if no column.

public static SqlParser getSqlParser(String sql) {
    SourceStringReader sqlReader = new SourceStringReader(sql);

    return SqlParser.create(sqlReader,
            SqlParser.configBuilder()
                    .setParserFactory(FlinkSqlParserImpl.FACTORY)
                    .setLex(Lex.JAVA)
                    .setIdentifierMaxLength(256)
                    .setConformance(FlinkSqlConformance.DEFAULT)
                    .build());
}

public static void main(String[] args) throws Exception {


    SqlParser sqlParser = getSqlParser("" +
            "create TEMPORARY table t_order_course (\n" +
            "   WATERMARK FOR last_update_time AS last_update_time - INTERVAL '5' SECOND\n" +
            ") with (\n" +
            "  'scan.startup.mode' = 'specific-offsets',\n" +
            "  'scan.startup.specific-offsets' = 'partition:0,offset:1169129'\n" +
            ") like cdc.`qq_data(sh-backend-tst:3306)`.t_order_course (\n" +
            "   OVERWRITING  WATERMARKS\n" +
            "   OVERWRITING OPTIONS\n" +
            "   EXCLUDING CONSTRAINTS\n" +
            " \n" +
            ")");
    SqlNode sqlNode = sqlParser.parseStmt();

    System.out.println(sqlNode.toString());

}

output:

CREATE TEMPORARY TABLE `t_order_course` WITH ( 'scan.startup.mode' = 'specific-offsets', 'scan.startup.specific-offsets' = 'partition:0,offset:1169129' ) LIKE `cdc`.`qq_data(sh-backend-tst:3306)`.`t_order_course` ( OVERWRITING WATERMARKS OVERWRITING OPTIONS EXCLUDING CONSTRAINTS )