[FLINK-22648] docker-entrypoint.sh categorically overwrites numberOfTaskSlots

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: docker-1.13.0.1
• Component/s: flink-docker
• Labels: pull-request-available
• Assignee: Chesnay Schepler
• Reporter: Chesnay Schepler
• Created: 12/May/21 12:28
• Updated: 18/May/21 10:36
• Resolved: 18/May/21 10:36

Description

The docker entrypoint always runs this code:

TASK_MANAGER_NUMBER_OF_TASK_SLOTS=${TASK_MANAGER_NUMBER_OF_TASK_SLOTS:-1}
set_config_option taskmanager.numberOfTaskSlots ${TASK_MANAGER_NUMBER_OF_TASK_SLOTS} 

This always overrides the number of task slots, either with the value that was set by the user or otherwise, 1.

This means that users cannot mount a different config to change the number of slots.

We should only configure the number of slots if the environment variable was actually set.

Issue Links

• links to: GitHub Pull Request #80