Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-22277

Refactor sql client's DynamicResult

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Table SQL / Client
    • Labels:

      Description

      Right now, the sql client Executor has different result handling logic for different result display mode. 

      Different result is handled by child classes of `DynamicResult`. 

      This leads to introducing page related API to the Executor, such as `snapshotResult`  and `retrieveResultPage`, which I think is inappropriate and will make things complicated. 

      It will be benefit to simplify the responsibility of Executor about retrieving results to simply streaming back the SELECT result, and move the logic of dealing with different display mode into CliResultView. 

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                ykt836 Kurt Young
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated: