Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-21638

Clean up argument order and semantics of all "stopWithSavepoint" calls in the codebase

    XMLWordPrintableJSON

Details

    Description

      This came up in a review: https://github.com/apache/flink/pull/14948#discussion_r588304475

      The stopWithSavepoint() methods in Flink have a boolean flag, indicating either whether we inject a MAX_WATERMARK in the pipeline, or whether we terminate or suspend a job.

      As part of this ticket, I propose to introduce a new enum type in flink-core "StopWithSavepointBehavior" with SUSPEND and TERMINATE fields and replace the boolean flag with this new field.

      Attachments

        Issue Links

          is related to

          Sub-task - The sub-task of the issue FLINK-21333 Introduce stopping with savepoint state

          • Major - Major loss of function.
          • Closed

          Activity

            People

              Unassigned Unassigned
              rmetzger Robert Metzger
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: