[FLINK-21626] Consider shaping newly introduced RuntimeContext.getJobId to return JobID with no Optional wrapper

• Type: Improvement
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.13.0
• Fix Version/s: 1.13.0
• Component/s: API / Core
• Labels: pull-request-available
• Assignee: Roman Khachatryan
• Reporter: Kezhu Wang
• Created: 05/Mar/21 07:33
• Updated: 28/Aug/21 10:34
• Resolved: 30/Mar/21 11:43

Description

Currently, this newly introduced RuntimeContext.getJobId() returns Optional<JobID>. The only path where it returns no job id is RuntimeUDFContext(through CollectionExecutor through CollectionEnvironment).

But after DataSet dropped, there will be no paths to return no job id. Both FLINK-21581 and my comment raised this concern. But different with FLINK-21581, I think we could return an environment/executor/plan level unique job id in RuntimeUDFContext for this new api. This way there will be no breaking change after DataSet dropped. And more importantly, a careful chosen job id does not hurt callers of RuntimeUDFContext in my opinion.

cc  chesnay roman_khachatryan aljoscha sewen 

Issue Links

• is caused by: FLINK-21581 Add PublicEvolving to RuntimeContext.jobId
• links to: GitHub Pull Request #15331