[FLINK-20098] Don't add flink-connector-files to flink-dist, make dependencies explicit

• Type: Improvement
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 1.12.0
• Component/s: API / DataStream
• Labels: pull-request-available
• Assignee: Aljoscha Krettek
• Reporter: Aljoscha Krettek
• Created: 11/Nov/20 18:22
• Updated: 10/Jun/21 14:34
• Resolved: 19/Nov/20 11:18

Description

We currently add both flink-connector-files and flink-connector-base to flink-dist.

This implies, that users should use the dependency like this:

<dependency>
	<groupId>org.apache.flink</groupId>
	<artifactId>flink-connector-files</artifactId>
	<version>${project.version}</version>
	<scope>provided</scope>
</dependency>

which differs from other connectors where users don't need to specify <scope>provided</scope>.

Also, flink-connector-files has flink-connector-base as a provided dependency, which means that examples that use this dependency will not run out-of-box in IntelliJ because transitive provided dependencies will not be considered.

I propose to just remove the dependencies from flink-dist and let users use the File Connector like any other connector.

I believe the initial motivation for "providing" the File Connector in flink-dist was to allow us to use the File Connector under the hood in methods such as StreamExecutionEnvironment.readFile(...). We could decide to deprecate and remove those methods or re-add the File Connector as an explicit (non-provided) dependency again in the future.

Issue Links

• causes: FLINK-22964 Connector-base exposes dependency to flink-core.
• causes: FLINK-20149 SQLClientKafkaITCase.testKafka failed with "Did not get expected results before timeout."
• is duplicated by: FLINK-20196 flink-connector-files needs explicit flink-connector-base dependency to run
• relates to: FLINK-21169 Kafka flink-connector-base dependency should be scope compile
• relates to: FLINK-20196 flink-connector-files needs explicit flink-connector-base dependency to run
• relates to: FLINK-18447 Add 'flink-connector-base' to 'flink-dist'
• links to: GitHub Pull Request #14044
• links to: GitHub Pull Request #14122