[FLINK-19684] The Jdbc-connector's 'lookup.max-retries' option implementation is different from the meaning

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.12.0
• Component/s: Connectors / JDBC
• Labels: pull-request-available
• Assignee: CaoZhen
• Reporter: CaoZhen
• Created: 16/Oct/20 15:09
• Updated: 27/Oct/20 14:09
• Resolved: 27/Oct/20 14:09

Description

 

The code of 'lookup.max-retries' option :

for (int retry = 1; retry <= maxRetryTimes; retry++) {
      statement.clearParameters();
      .....
}  

From the code, If this option is set to 0, the JDBC query will not be executed.

 

From documents,  the max retry times if lookup database failed. [1]

When set to 0, there is a query, but no retry.

 

So,the code of 'lookup.max-retries' option should be:

for (int retry = 0; retry <= maxRetryTimes; retry++) {
      statement.clearParameters();
      .....
}  

 

 

[1] https://ci.apache.org/projects/flink/flink-docs-release-1.11/dev/table/connectors/jdbc.html#lookup-max-retries

Issue Links

• links to: GitHub Pull Request #13669