[FLINK-19468] Metrics return empty when data stream / operator name contains "+"

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Later
• Affects Version/s: 1.9.0, 1.9.2, 1.9.3
• Component/s: API / DataStream, Runtime / Metrics
• Labels: pull-request-available
• Assignee: Boyang Jerry Peng
• Reporter: Boyang Jerry Peng
• Created: 29/Sep/20 22:50
• Updated: 07/Dec/20 13:51
• Resolved: 07/Dec/20 13:49

Description

If I submit a Flink job in which a stream has a name that contains a "+" character, the metrics returned for the stream is always empty.  For example:

```

env.addSource(new TestSource()).name("testing + plus");
```

 

If I try to get the metrics
```

$ curl http://localhost:8081/jobs/5d4f28a221b2e5762f8404398a462eb0/vertices/cbc357ccb763df2852fee8c4fc7d55f2/metrics?get=0.Source__testing_+_plus.numRecordsOut

[]
```

 

The http request is also made from the UI if you view the metric "0.Source_testing+_plus.numRecordsOut".

The metrics will always return empty.  However if I remove the "+" from the name of the stream.  Metrics are returned non-empty.

Maybe it has something to do with this method:

https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricQueryService.java#L208

It does not consider "+" character?

 

I have attached the full example to reproduce the issue.

Issue Links

• is related to: FLINK-20518 WebUI should escape characters in metric names
• is related to: FLINK-20520 Document that metric names can contain characters that need to be escaped
• links to: GitHub Pull Request #13514