[FLINK-19443] runtime function 'splitIndex'

• Type: Bug
• Status: Closed
• Priority: Not a Priority
• Resolution: Invalid
• Component/s: Table SQL / Runtime
• Assignee: Unassigned
• Reporter: Mengyang Tang
• Created: 29/Sep/20 03:56
• Updated: 03/Aug/21 02:26
• Resolved: 03/Aug/21 02:26

Description

runtime function 'splitIndex' has NPE problem (located in the SqlFunctionUtils class)

 

NPE version:

public static String splitIndex(String str, String separator, int index) {
    if (index < 0)

{         return null;     }
    String[] values = StringUtils.splitByWholeSeparatorPreserveAllTokens(str, separator);
    if (index >= values.length) {         return null;     }

else

{         return values[index];     }
}

public static String splitIndex(String str, int character, int index) {
    if (character > 255 || character < 1 || index < 0) {         return null;     }
    String[] values = StringUtils.splitPreserveAllTokens(str, (char) character);
    if (index >= values.length) {         return null;     } else {         return values[index];     }

}

 

Fix version:

public static String splitIndex(String str, String separator, int index) {
    if (index < 0)

{         return null;     }
    String[] values = StringUtils.splitByWholeSeparatorPreserveAllTokens(str, separator);
    if (values == null || index >= values.length) {         return null;     }

else

{         return values[index];     }
}

public static String splitIndex(String str, int character, int index) {
    if (character > 255 || character < 1 || index < 0) {         return null;     }
    String[] values = StringUtils.splitPreserveAllTokens(str, (char) character);
    if (values == null || index >= values.length) {         return null;     } else {         return values[index];     }

}