[FLINK-18993] Invoke sanityCheckTotalFlinkMemory method incorrectly in JobManagerFlinkMemoryUtils.java

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.11.0
• Fix Version/s: 1.11.2, 1.12.0
• Component/s: Runtime / Configuration
• Labels: pull-request-available
• Assignee: Peng
• Reporter: Peng
• Created: 19/Aug/20 01:56
• Updated: 21/Aug/20 16:51
• Resolved: 21/Aug/20 16:51

Description

In deriveFromRequiredFineGrainedOptions method from JobManagerFlinkMemoryUtils.java, it will call sanityCheckTotalFlinkMemory method to check heap, off-heap and total memory as below.

sanityCheckTotalFlinkMemory(totalFlinkMemorySize, jvmHeapMemorySize, totalFlinkMemorySize);

As I understand it, the third argument should be offHeapMemorySize.

sanityCheckTotalFlinkMemory(totalFlinkMemorySize, jvmHeapMemorySize, offHeapMemorySize);

 

Issue Links

• links to: GitHub Pull Request #13198