[FLINK-18348] RemoteInputChannel should checkError before checking partitionRequestClient

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.11.0, 1.12.0
• Fix Version/s: 1.11.0
• Component/s: Runtime / Network
• Labels: pull-request-available
• Assignee: Jiayi Liao
• Reporter: Jiayi Liao
• Created: 17/Jun/20 12:33
• Updated: 23/Jun/20 15:57
• Resolved: 23/Jun/20 15:56

Description

The error will be set and partitionRequestClient will be a null value if a remote channel fails to request the partition at the beginning. And the task will fail here when the task thread trying to fetch data from channels.

And then we get error:

java.lang.IllegalStateException: Queried for a buffer before requesting a queue.
        at org.apache.flink.util.Preconditions.checkState(Preconditions.java:195) ~[flink-dist_2.11-1.11-SNAPSHOT.jar:1.11-SNAPSHOT]
        at org.apache.flink.runtime.io.network.partition.consumer.RemoteInputChannel.getNextBuffer(RemoteInputChannel.java:172) ~[flink-dist_2.11-1.11-SNAPSHOT.jar:1.11-SNAPSHOT]
        at org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate.waitAndGetNextData(SingleInputGate.java:637) ~[flink-dist_2.11-1.11-SNAPSHOT.jar:1.11-SNAPSHOT]
        at org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate.getNextBufferOrEvent(SingleInputGate.java:615) ~[flink-dist_2.11-1.11-SNAPSHOT.jar:1.11-SNAPSHOT]
        at org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate.getNext(SingleInputGate.java:598) ~[flink-dist_2.11-1.11-SNAPSHOT.jar:1.11-SNAPSHOT]

But the root cause is the PartitionConnectionException we set when requesting the partition.

Issue Links

• links to: GitHub Pull Request #12706