[FLINK-18325] NPE may throw when use SqlDataTypeSpec#getNullable

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 1.12.0
• Component/s: Table SQL / Runtime
• Labels: pull-request-available
• Assignee: Jiatao Tao
• Reporter: Jiatao Tao
• Created: 16/Jun/20 10:54
• Updated: 04/Nov/20 02:17
• Resolved: 04/Nov/20 02:17

Description

SqlMapTypeNameSpec#unparse calls SqlDataTypeSpec#getNullable, and "getNullable" may throw NPE

if (!keyType.getNullable()) { 
  writer.keyword("NOT NULL"); 
}

 

See in  SqlDataTypeSpec 

/** Whether data type allows nulls.
 *
 * <p>Nullable is nullable! Null means "not specified". E.g.
 * {@code CAST(x AS INTEGER)} preserves the same nullability as {@code x}.
 */
private Boolean nullable;

 

This API is from calcite, and all callers will determine if it is null:

 

 

Issue Links

• links to: GitHub Pull Request #12702
• links to: GitHub Pull Request #13836