[FLINK-17818] CSV Reader with Pojo Type and no field names fails

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.10.1
• Fix Version/s: 1.12.0
• Component/s: API / DataSet
• Labels: pull-request-available
• Assignee: Danish Amjad
• Reporter: Danish Amjad
• Created: 19/May/20 20:10
• Updated: 19/Feb/21 07:30
• Resolved: 29/Sep/20 09:54

Description

When a file is read with a CSVReader and a POJO is specified and the filed names are not specified, the output is obviously not correct. The API is not throwing any error despite a null check inside the API. i.e.

Preconditions.checkNotNull(pojoFields, "POJO fields must be specified (not null) if output type is a POJO.");

The root cause of the problem is that the fieldNames argument is a variable argument and the variable is 'empty but not null' when not given any value. So, the check passes without failing.

I am not sure if it is a feature of the API or an actual bug because there is a test checking the NPE when a null is passed.

Issue Links

• links to: GitHub Pull Request #13367