[FLINK-17222] Improve FieldsDataType

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.11.0
• Component/s: Table SQL / API
• Labels: pull-request-available
• Assignee: Timo Walther
• Reporter: Dawid Wysakowicz
• Created: 17/Apr/20 13:59
• Updated: 14/May/20 18:15
• Resolved: 14/May/20 18:15

Description

The problem with FieldsDataType is that the method getFieldDataTypes does not keep the order of the fields stored in the logical type. Therefore at couple of locations we have to first iterate over the names in logical type and then get the DataTypes.

final RowType rowType = (RowType) fieldsDataType.getLogicalType();
final String[] fieldNames = rowType.getFields()
	.stream()
	.map(RowType.RowField::getName)
	.toArray(String[]::new);

final TypeInformation<?>[] fieldTypes = Stream.of(fieldNames)
	.map(name -> fieldsDataType.getFieldDataTypes().get(name))
	.map(LegacyTypeInfoDataTypeConverter::toLegacyTypeInfo)
	.toArray(TypeInformation[]::new);

Issue Links

• links to: GitHub Pull Request #12121