Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-17036

Datadog forwarder does not allow for EU endpoint

    XMLWordPrintableJSON

    Details

      Description

      Please note I am a current Datadog employee. https://github.com/apache/flink/pull/11661

      Essentially the FLINK integration does not work in the EU instance due to:

      https://github.com/apache/flink/blob/master/flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java#L45

      `.com` is hardcoded. Datadog has two endpoints `.com` and `.eu` both need to be accounted for or EU customers cannot use the integration. https://docs.datadoghq.com/agent/basic_agent_usage/?tab=agentv6v7#datadog-site

      As a quick suggestion I put together a PR that would account for this. Please note I am not a software Engineer so this is very much a starting point.

      I followed the below to ensure it builds:

      ```
      {{ git clone https://github.com/apache/flink.git}}
      {{ cd flink}}
      {{ mvn clean package -DskipTests # this will take up to 10 minutes}}
      {{ ```}}

      Made some changes and did a rough build on this which was successful:

      {{ ```}}
      {{ raymond.farrelly@RFM flink % mvn clean -pl :flink-metrics-datadog}}
      {{ ...}}
      {{ [INFO] }}
      {{ [INFO] --------------< org.apache.flink:flink-metrics-datadog >--------------}}
      {{ [INFO] Building flink-metrics-datadog 1.11-SNAPSHOT}}
      {{ [INFO] -------------------------------[ jar ]--------------------------------}}
      {{ [INFO] }}
      {{ [INFO] — maven-clean-plugin:3.1.0:clean (default-clean) @ flink-metrics-datadog —}}
      {{ [INFO] Deleting /Users/raymond.farrelly/Documents/flink/flink-metrics/flink-metrics-datadog/target}}
      {{ [INFO] ------------------------------------------------------------------------}}
      {{ [INFO] BUILD SUCCESS}}
      {{ [INFO] ------------------------------------------------------------------------}}
      {{ [INFO] Total time: 1.292 s}}
      {{ [INFO] Finished at: 2020-04-02T18:06:18+01:00}}
      {{ [INFO] ------------------------------------------------------------------------}}
      {{ raymond.farrelly@RFM flink % }}
      {

      { ```}

      }

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                RaymondFarrelly Raymond Farrelly
                Reporter:
                RaymondFarrelly Raymond Farrelly
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m