[FLINK-16942] ES 5 sink should allow users to select netty transport client

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.9.0, 1.10.0, 1.11.0
• Fix Version/s: 1.9.3, 1.10.1, 1.11.0
• Component/s: Connectors / ElasticSearch
• Labels: pull-request-available
• Assignee: Chesnay Schepler
• Reporter: Chesnay Schepler
• Created: 02/Apr/20 08:59
• Updated: 17/Apr/20 02:24
• Resolved: 03/Apr/20 06:30

Description

When assembling the settings for the PreBuiltTransportClient the Elasticsearch5ApiCallBridge first adds the user-provided client and then overrides http/transport types with netty 3.

This means that users are forced to use netty 3, despite the connector being able to work with a more recent and secure version.

Settings settings = Settings.builder().put(clientConfig)
	.put(NetworkModule.HTTP_TYPE_KEY, Netty3Plugin.NETTY_HTTP_TRANSPORT_NAME)
	.put(NetworkModule.TRANSPORT_TYPE_KEY, Netty3Plugin.NETTY_TRANSPORT_NAME)
	.build();

We should invert the order in which the settings are added.

Issue Links

• links to: GitHub Pull Request #11616