[FLINK-16703] AkkaRpcActor state machine does not record transition to terminating state.

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.8.0, 1.9.0, 1.10.0, 1.11.0, 2.0.0
• Fix Version/s: 1.9.3, 1.10.1, 1.11.0
• Component/s: Runtime / Coordination
• Labels: pull-request-available
• Assignee: Till Rohrmann
• Reporter: Dmitri Chmelev
• Created: 21/Mar/20 01:19
• Updated: 31/Mar/20 10:46
• Resolved: 31/Mar/20 10:46

Description

As part of FLINK-11551, the state machine of AkkaRpcActor has been updated to include 'terminating' and 'terminated' states. However, when actor termination request is handled, the resulting 'terminating' state is not updated by the FSM.

https://github.com/apache/flink/blame/master/flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcActor.java#L175

As a side-effect, isRunning() predicate can return that the actor is still running after terminate was initiated and to still handle messages.

I believe the fix is trivial and the private field state should be updated with the return value of the call to state.terminate().

Feel free to adjust the priority accordingly.

Issue Links

• links to: GitHub Pull Request #11549