[FLINK-15919] MemoryManager shouldn't allow releasing more memory than reserved

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.10.0
• Fix Version/s: 1.10.0
• Component/s: Runtime / Task
• Labels: pull-request-available
• Assignee: Yu Li
• Reporter: Yu Li
• Created: 05/Feb/20 12:15
• Updated: 07/Feb/20 20:14
• Resolved: 06/Feb/20 12:19

Description

Currently MemoryManager allows releasing more memory than reserved for the same owner object, which could be reproduced by adding below test case into MemoryManagerTest:

	@Test
	public void testMemoryReleaseGuard() throws MemoryReservationException {
		Object owner = new Object();
		Object owner2 = new Object();

		long totalHeapMemorySize = memoryManager.availableMemory(MemoryType.HEAP);
		memoryManager.reserveMemory(owner, MemoryType.HEAP, PAGE_SIZE);
		memoryManager.reserveMemory(owner2, MemoryType.HEAP, PAGE_SIZE);
		memoryManager.releaseMemory(owner, MemoryType.HEAP, PAGE_SIZE);
		memoryManager.releaseMemory(owner, MemoryType.HEAP, PAGE_SIZE);
		long heapMemoryLeft = memoryManager.availableMemory(MemoryType.HEAP);
		assertEquals("Memory leak happens", totalHeapMemorySize - PAGE_SIZE, heapMemoryLeft);
		memoryManager.releaseAllMemory(owner2, MemoryType.HEAP);
	}

Issue Links

• links to: GitHub Pull Request #11025