[FLINK-15691] TaskExecutorPartitionLifecycleTest#runInTaskExecutorThreadAndWait does not run in main thread

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.9.0
• Fix Version/s: 1.10.0
• Component/s: Runtime / Coordination, Tests
• Labels: pull-request-available
• Assignee: Chesnay Schepler
• Reporter: Till Rohrmann
• Created: 20/Jan/20 15:20
• Updated: 24/Jan/20 08:58
• Resolved: 23/Jan/20 14:58

Description

The method TaskExecutorPartitionLifecycleTest#runInTaskExecutorThreadAndWait does not run the given runnable in the TaskExecutors main thread. Instead it will run it in an arbitrary thread of the RpcService.

The reason why this does not cause test instabilities is that we execute operations which don't cause race conditions. However, in order to avoid spreading false friends I would suggest to get rid of this pattern. Moreover, I would question whether TaskExecutorPartitionLifecycleTest really needs access to the TaskExecutors internal state. I believe there is an easy way using the TaskExecutors public API to implement the tests.

cc chesnay, azagrebin

Issue Links

• links to: GitHub Pull Request #10923