[FLINK-15660] Redundant AllocationID verification for allocateSlot in TaskSlotTable

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.10.0
• Fix Version/s: 1.13.0
• Component/s: Runtime / Coordination
• Assignee: Unassigned
• Reporter: xiajun
• Created: 19/Jan/20 07:42
• Updated: 08/Jan/21 10:33
• Resolved: 08/Jan/21 10:33

Description

 

In function TaskSlotTable::allocateSlot, first we will check whether allocationId is exist, when exist we will refused this allocation, this was introduced by FLINK-14589 . But in FLINK-14189, when allocationId exist, we think this is valid, which is contradictory with the first check.

 The code is following:

https://github.com/apache/flink/blob/310452e800355f0dcc4bc9dd26e9cecba263f3d6/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTable.java#L261