[FLINK-14926] Make sure no resource leak of RocksObject

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.4, 1.7.2, 1.8.2, 1.9.1
• Fix Version/s: 1.10.0
• Component/s: Runtime / State Backends
• Labels: pull-request-available
• Release Note: Interfaces OptionsFactory and ConfigurableOptionsFactory have been deprecated in favor of RocksDBOptionsFactory and ConfigurableRocksDBOptionsFactory, respectively.
• Assignee: Yu Li
• Reporter: Yu Li
• Created: 22/Nov/19 08:02
• Updated: 03/Feb/20 12:16
• Resolved: 18/Dec/19 16:33

Description

When investigating FLINK-14484 to allow setting WriteBufferManager via options, we find it necessary to supply a close method in OptionsFactory to make sure resources configured in options like WriteBufferManager could/would be released.

What's more, we're having potential risk of resource leak in PredefinedOptions such as the created BloomFilter instance is never closed (regression caused by FLINK-7220 changes), and we should also fix this and add a close method in PredefinedOptions

Issue Links

• causes: FLINK-15199 Benchmarks are not compiling
• links to: GitHub Pull Request #10300
• links to: GitHub Pull Request #10517