Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-14801

Improve the local variable name in SqlCreateTable#unparser()

    XMLWordPrintableJSON

    Details

      Description

      in the class org.apache.flink.sql.parser.ddl.SqlCreateTable#unparse

      //代码占位符
      if (this.partitionKeyList != null && this.partitionKeyList.size() > 0) { 
            writer.newlineAndIndent(); writer.keyword("PARTITIONED BY"); 
            SqlWriter.Frame withFrame = writer.startList("(", ")");
            this.partitionKeyList.unparse(writer, leftPrec, rightPrec); 
            writer.endList(withFrame);
            writer.newlineAndIndent();
       }
      
      

      it's better to modify name withFrame to partitionedByFrame

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                xiaodao xiaodao
                Reporter:
                xiaodao xiaodao
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m