[FLINK-14384] ValidationMatcher in FlinkSqlParserImplTest fails to test negative tests

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 1.9.0
• Component/s: Table SQL / Planner
• Labels: stale-major test-stability
• Assignee: Unassigned
• Reporter: Jiayi Liao
• Created: 13/Oct/19 07:47
• Updated: 29/Apr/21 13:05
• Resolved: 29/Apr/21 13:05

Description

In ValidationMatcher we use failMsg to test exception. However the sql can be validated successfully without throwing a exception and #matches method returns true finally.

 

Take #testInsertWithInvalidPartitionColumns as an example, you can succeed this tests even though you create a wrong failMsg.