[FLINK-14362] Change DefaultSchedulingResultPartition to return correct partition state

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.10.0
• Fix Version/s: 1.10.0
• Component/s: Runtime / Coordination
• Labels: pull-request-available
• Assignee: Zhu Zhu
• Reporter: Zhu Zhu
• Created: 10/Oct/19 08:51
• Updated: 20/Nov/19 16:18
• Resolved: 20/Nov/19 16:18

Description

Currently DefaultSchedulingResultPartition#getState() returns the state of partitions based on the partition producer's state. The state is used to make scheduling decision.

However, it does not correctly reflect the true state of a partition.
For example, when producer task turns to RUNNING but has not produced any data yet, it's consumers should not be scheduled to reduce unnecessary resource cost in lazy scheduling mode. However, the partition state will be RUNNING in DefaultSchedulingResultPartition and will trigger the scheduling of its consumers. This may lead to some vertices scheduled earlier than expected with no data to consume, which means a waste of resources.

I'd propose to change the enums in ResultPartitionState to be:

• CREATED // partition is just created or is just reset
• CONSUMABLE // pipelined partition has data produced or blocking partition's parent result finishes. Corresponds to IntermediateResultPartition#isConsumable.

The CONSUMABLE state is what the scheduler really cares to make scheduling decisions.
The DefaultResultPartition should be fixed to return ResultPartitionState based the true partition state, rather than the vertex state.

Issue Links

• links to: GitHub Pull Request #10237