[FLINK-14273] Improve exception message when signature validation of UDAF is failed

• Type: Improvement
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.9.0
• Fix Version/s: 1.10.0
• Component/s: Table SQL / Planner
• Labels: pull-request-available
• Assignee: hailong wang
• Reporter: hailong wang
• Created: 29/Sep/19 08:56
• Updated: 12/Oct/19 08:00
• Resolved: 12/Oct/19 08:00

Description

When UDAF parameters are inconsistent with the definition of accumulate method, all arguments to the accumulate method are listed in the error. But the first argument of accumulate is accumulator, users don't have to care when using SQL.

For example:

INSERT INTO Orders SELECT name, USERUDAF(id, name) FROM Orders GROUP BY TUMBLE(rowTime, interval '10' second ), id, name

USERUDAF is a User-Defined Aggregate Functions, and accumulate is defined as follow:

public void accumulate(Long acc, String a) {……}

At present, error is as follows:

Caused by: org.apache.flink.table.api.ValidationException: Given parameters of function do not match any signature. 
Actual: (java.lang.Integer, java.lang.String) 
Expected: (java.lang.Integer, java.lang.String)

This error will mislead users, and the expected errors are as follows :

Caused by: org.apache.flink.table.api.ValidationException: Given parameters of function do not match any signature. 
Actual: (java.lang.Integer, java.lang.String) 
Expected: (java.lang.String)

Issue Links

• links to: GitHub Pull Request #9823