[FLINK-13967] Generate full binary licensing via collect_license_files.sh

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.8.3, 1.9.1, 1.10.0
• Component/s: Build System
• Labels: pull-request-available
• Assignee: Chesnay Schepler
• Reporter: Chesnay Schepler
• Created: 05/Sep/19 07:24
• Updated: 06/Sep/19 10:13
• Resolved: 06/Sep/19 10:13

Description

Currently, collect_license_files.sh is a generic tool to collect licenses and it concatenates NOTICE files from jars contained in a given directory.
In practice though this script is only used to assemble the NOTICE-binary file and licenses-binary directory.

To make the script more user-friendly I propose to

1. add the `-binary` suffix to the generate file/directory
2. automatically add the NOTICE-binary header
3. automatically add the LICENSE.slf4j file

With this we can generate the entire binary licensing without and additional steps being required, which will also make it easy to add an automatic check for the correctness of said licensing.

Issue Links

• links to: GitHub Pull Request #9624