[FLINK-13880] The behavior of JobExecutionResult.getAccumulatorResult does not match its java doc

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.11.0
• Fix Version/s: 1.11.0
• Component/s: API / Core
• Labels: pull-request-available
• Assignee: Caizhi Weng
• Reporter: Caizhi Weng
• Created: 28/Aug/19 05:34
• Updated: 15/Apr/20 07:33
• Resolved: 15/Apr/20 07:33

Description

The java doc of `JobExecutionResult.getAccumulatorResult` states that "Returns {@code null}, if no accumulator with that name was produced", but actually an NPE will be triggered if no accumulator with that name is produced.

I'm going to rewrite the `getAccumulatorResult` method to the following:

public <T> T getAccumulatorResult(String accumulatorName) {
   OptionalFailure<Object> result = this.accumulatorResults.get(accumulatorName);
   if (result != null) {
      return (T) result.getUnchecked();
   } else {
      return null;
   }
}

Please assign this issue to me if this solution is acceptable.

 

Issue Links

• links to: GitHub Pull Request #11698