[FLINK-13827] Shell variable should be escaped in start-scala-shell.sh

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.9.0, 1.10.0
• Fix Version/s: 1.9.2, 1.10.0
• Component/s: Scala Shell
• Labels: pull-request-available
• Assignee: Zili Chen
• Reporter: Zili Chen
• Created: 23/Aug/19 08:08
• Updated: 16/Oct/20 10:51
• Resolved: 07/Oct/19 12:00

Description

diff --git a/flink-scala-shell/start-script/start-scala-shell.sh b/flink-scala-shell/start-script/start-scala-shell.sh
index b6da81af72..65b9045584 100644
--- a/flink-scala-shell/start-script/start-scala-shell.sh
+++ b/flink-scala-shell/start-script/start-scala-shell.sh
@@ -97,9 +97,9 @@ log_setting="-Dlog.file="$LOG" -Dlog4j.configuration=file:"$FLINK_CONF_DIR"/$LOG
 
 if ${EXTERNAL_LIB_FOUND}
 then
-    $JAVA_RUN -Dscala.color -cp "$FLINK_CLASSPATH" $log_setting org.apache.flink.api.scala.FlinkShell $@ --addclasspath "$EXT_CLASSPATH"
+    $JAVA_RUN -Dscala.color -cp "$FLINK_CLASSPATH" "$log_setting" org.apache.flink.api.scala.FlinkShell $@ --addclasspath "$EXT_CLASSPATH"
 else
-    $JAVA_RUN -Dscala.color -cp "$FLINK_CLASSPATH" $log_setting org.apache.flink.api.scala.FlinkShell $@
+    $JAVA_RUN -Dscala.color -cp "$FLINK_CLASSPATH" "$log_setting" org.apache.flink.api.scala.FlinkShell $@
 fi
 
 #restore echo

otherwise it is error prone when $log_setting contain arbitrary content.

For example, if the parent dir contain whitespace, said flink-1.9.0 2, then bin/start-scala-shell.sh local will fail with

Error: Could not find or load main class 2.log.flink-*-scala-shell-local-*.log

Issue Links

• causes: FLINK-17763 No log files when starting scala-shell
• links to: GitHub Pull Request #9800
• links to: GitHub Pull Request #9834
• links to: GitHub Pull Request #12213