Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-13332

PackagedProgram#isUsingInteractiveMode implemented error prone

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Not A Problem
    • Affects Version/s: 1.10.0
    • Fix Version/s: None
    • Component/s: Command Line Client
    • Labels:
      None

      Description

      Currently, PackagedProgram#isUsingInteractiveMode implemented as

      public boolean isUsingInteractiveMode() {
          return this.program == null;
      }
      

      is hacky and a better implementation would be

      public boolean isUsingInteractiveMode() {
          return hasMainMethod(mainClass);
      }
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                tison Zili Chen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: