[FLINK-13224] TupleTypeInfoBase equals function can't distinguish different struct type

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.8.0
• Component/s: API / Type Serialization System

Environment

flink 1.8.0

• Assignee: Unassigned
• Reporter: forideal
• Created: 11/Jul/19 12:47
• Updated: 17/Oct/19 09:22
• Resolved: 17/Oct/19 09:22

Description

Hi

i have two struct type

one is

// code placeholder
Types.ROW_NAMED(
         new String[]{"device"},
         Types.PRIMITIVE_ARRAY(Types.BYTE)

)

the other is

 

// code placeholder
Types.ROW_NAMED(
         new String[]{"app"},
         Types.PRIMITIVE_ARRAY(Types.BYTE)

)

when i compare those two types ,the equals function returns true.

there are some code in TupleTypeInfoBase         

// code placeholder
return other.canEqual(this) &&
           super.equals(other) &&
       Arrays.equals(types, other.types) &&
       totalFields == other.totalFields;

i think,The equals function should compare field names.

eg:

// code placeholder
if (totalFields == other.totalFields) {
             String[] otherFieldNames = other.getFieldNames();
             String[] fieldNames = this.getFieldNames();
             for (int i = 0; i < totalFields; i++) {
                 if (!otherFieldNames[i].equals(fieldNames[i])) {
                     return false;
                 }
             }
 } else{
   return false;
 }

return other.canEqual(this) &&
   super.equals(other) &&
   Arrays.equals(types, other.types);