[FLINK-13130] Reduce code duplication in AbstractYarnClusterDescriptor

• Type: Technical Debt
• Status: Reopened
• Priority: Not a Priority
• Resolution: Unresolved
• Affects Version/s: 1.8.0, 1.8.1
• Component/s: Deployment / YARN
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Charles Xu
• Created: 06/Jul/19 09:08
• Updated: 11/Aug/21 12:51

Description

There are two places checks variables HADOO_CONF_DIR or YARN_CONF_DIR. It's better to extract a method and call it separately. 

// check if required Hadoop environment variables are set. If not, warn user
private void checkEnvironmentVariables() {
    if (System.getenv("HADOOP_CONF_DIR") == null &&
        System.getenv("YARN_CONF_DIR") == null) {
            LOG.warn("Neither the HADOOP_CONF_DIR nor the YARN_CONF_DIR environment variable is set. " +
                "The Flink YARN Client needs one of these to be set to properly load the Hadoop " +
                "configuration for accessing YARN.");
    }
}

 

Issue Links

• links to: GitHub Pull Request #9005
• links to: GitHub Pull Request #9182