[FLINK-13077] CatalogPartitionAPICompletenessTests in pyflink failed because of lacking "getComment" method

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 1.9.0
• Component/s: API / Python, Tests
• Labels: pull-request-available
• Assignee: Wei Zhong
• Reporter: Wei Zhong
• Created: 03/Jul/19 09:27
• Updated: 03/Jul/19 11:45
• Resolved: 03/Jul/19 11:45

Description

The following exception will be thrown:

self = <pyflink.table.tests.test_catalog_completeness.CatalogPartitionAPICompletenessTests testMethod=test_completeness>

    def test_completeness(self):
>       self.check_methods()

pyflink/testing/test_case_utils.py:210: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

cls = <class 'pyflink.table.tests.test_catalog_completeness.CatalogPartitionAPICompletenessTests'>

    @classmethod
    def check_methods(cls):
        java_primary_methods = {'getClass', 'notifyAll', 'equals', 'hashCode', 'toString',
                                'notify', 'wait'}
        java_methods = PythonAPICompletenessTestCase.get_java_class_methods(cls.java_class())
        python_methods = cls.get_python_class_methods(cls.python_class())
        missing_methods = java_methods - python_methods - cls.excluded_methods() \
            - java_primary_methods
        if len(missing_methods) > 0:
            raise Exception('Methods: %s in Java class %s have not been added in Python class %s.'
>                           % (missing_methods, cls.java_class(), cls.python_class()))
E           Exception: Methods: set([u'getComment']) in Java class org.apache.flink.table.catalog.CatalogPartition have not been added in Python class <class 'pyflink.table.catalog.CatalogPartition'>.

After a quick investigation of this issue, it seem that it is introduced in the commit and PR as follows:

• https://github.com/apache/flink/commit/59ff00d71d298fa61a92efa4fecd46f3cefc50f6
• https://github.com/apache/flink/pull/8926

Issue Links

• links to: GitHub Pull Request #8968