[FLINK-13073] BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.9.0
• Fix Version/s: 1.9.0
• Component/s: Table SQL / Runtime
• Labels: pull-request-available
• Assignee: Louis Xu
• Reporter: Louis Xu
• Created: 03/Jul/19 06:37
• Updated: 04/Jul/19 11:19
• Resolved: 04/Jul/19 11:19

Description

BinaryRow which in blink runtime module has static constant named FIRST_BYTE_ZERO, it's purpose is to filter first byte。

Use 0xFFF0 as a exsample:

its binary sequence is: 1111111111110000。It has 2 problems:

1. It can only skip 4 bits of header. If the header is big than 15, then any return long value from pos 0 intersect with FIRST_BYTE_ZERO will not equal to 0. Then will always return true.
2. It only can check 8 bit(0-7) of null fields, which left 8-55 bit of null field unchecked.

Issue Links

• links to: GitHub Pull Request #8961