[FLINK-11867] Fix empty path check in StreamExEnv#readTextFile

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.3, 1.8.0
• Component/s: API / DataStream
• Labels: pull-request-available
• Assignee: Tom Goong
• Reporter: Tom Goong
• Created: 09/Mar/19 15:53
• Updated: 15/Mar/19 12:36
• Resolved: 11/Mar/19 14:29

Description

In class StreamExecutionEnvironment

 

// code placeholder
public DataStreamSource<String> readTextFile(String filePath, String charsetName) {
Preconditions.checkNotNull(filePath, "The file path must not be null.");
Preconditions.checkNotNull(filePath.isEmpty(), "The file path must not be empty.");

TextInputFormat format = new TextInputFormat(new Path(filePath));
format.setFilesFilter(FilePathFilter.createDefaultFilter());
TypeInformation<String> typeInfo = BasicTypeInfo.STRING_TYPE_INFO;
format.setCharsetName(charsetName);

return readFile(format, filePath, FileProcessingMode.PROCESS_ONCE, -1, typeInfo);
}

 

the Preconditions.checkNotNull(filePath.isEmpty(), "The file path must not be empty."); this will not work

Issue Links

• links to: GitHub Pull Request #7947