Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-11832

Convert some InternalType property related functions to InternalType's method

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Invalid
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Table SQL / Planner
    • Labels:
      None

      Description

      For example, in `CodeGenUtils` we have some utils methods like `needCopyForType` and `needCloneRefForType`. They are very error prone because there is no guarantee when someone add a new InternalType, he will check this functionality. 

      There also exists some pattern-match style codes based on types, i think a feasible principle when to convert these to class's method and when to keep they as pattern-match is:

      "If the pattern-match codes stand for all further changes, we can keep it as it is. Otherwise, we should convert it to class's method as much as possible". 

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                ykt836 Kurt Young
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: