[FLINK-11663] Remove control flow break point from Execution#releaseAssignedResource

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.8.0
• Component/s: Runtime / Coordination
• Labels: pull-request-available
• Assignee: Till Rohrmann
• Reporter: Till Rohrmann
• Created: 19/Feb/19 15:04
• Updated: 20/Feb/19 09:17
• Resolved: 20/Feb/19 09:16

Description

In Execution#releaseAssignedResource we release the assigned resource by calling LogicalSlot#releaseSlot and use FutureUtils.whenCompleteAsyncIfNotDone to merge the future back into the main thread in order to complete the Execution#releaseFuture. This is no longer necessary since the returned future is always completed from within the main thread (with the changes from FLINK-10431).

In fact this control flow break point makes it hard to properly suspend the ExecutionGraph atomically as required for FLINK-11537.

Issue Links

• links to: GitHub Pull Request #7755