[FLINK-11316] JarFileCreatorTest fails when run with Java 9

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.8.0
• Component/s: Tests
• Labels: pull-request-available tests
• Assignee: Zili Chen
• Reporter: Gary Yao
• Created: 14/Jan/19 14:15
• Updated: 26/Jan/19 15:31
• Resolved: 26/Jan/19 15:30

Description

Description
JarFileCreatorTest fails when run with Java 9. Because JarFileCreator is not used in production, the class and its tests can be deleted.

Stacktrace:

java.lang.IllegalArgumentException
	at org.apache.flink.shaded.asm5.org.objectweb.asm.ClassReader.<init>(Unknown Source)
	at org.apache.flink.shaded.asm5.org.objectweb.asm.ClassReader.<init>(Unknown Source)
	at org.apache.flink.shaded.asm5.org.objectweb.asm.ClassReader.<init>(Unknown Source)
	at org.apache.flink.runtime.util.JarFileCreator.addDependencies(JarFileCreator.java:146)
	at org.apache.flink.runtime.util.JarFileCreator.createJarFile(JarFileCreator.java:178)
	at org.apache.flink.runtime.util.JarFileCreatorTest.TestAnonymousInnerClassTrick1(JarFileCreatorTest.java:57)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:564)

Steps to reproduce
With the Java 9 compiler in the path, run:

mvn test -Pjava9 -DfailIfNoTests=false -Dfast -Dtest=org.apache.flink.runtime.util.JarFileCreatorTest

Alternatively, run the test from IntelliJ with the java9 profile enabled.

Acceptance Criteria

• JarFileCreator and JarFileCreatorTest are deleted
• Usage of JarFileCreator in ClassLoaderUtilsTest#testWithURLClassLoader is replaced with an alternative

Issue Links

• supercedes: FLINK-9520 JarFileCreator does not support Java MethodReferences
• links to: GitHub Pull Request #7486