[FLINK-11167] Optimize RocksDBList#put for no empty input

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Implemented
• Fix Version/s: 1.9.0
• Component/s: Runtime / State Backends
• Labels: pull-request-available
• Assignee: Congxian Qiu
• Reporter: Congxian Qiu
• Created: 14/Dec/18 10:04
• Updated: 29/Apr/19 08:16
• Resolved: 29/Apr/19 08:16

Description

In `RocksDBListState.putInternal` we will first remove the current state and then add the new list if needed(list is no empty) such as below.

I think if the list is not empty, we could skip the remove operation.

 

public void updateInternal(List<V> values) {
   Preconditions.checkNotNull(values, "List of values to add cannot be null.");

   clear();

   if (!values.isEmpty()) {
      try {
         writeCurrentKeyWithGroupAndNamespace();
         byte[] key = dataOutputView.getCopyOfBuffer();
         byte[] premerge = getPreMergedValue(values, elementSerializer, dataOutputView);
         backend.db.put(columnFamily, writeOptions, key, premerge);
      } catch (IOException | RocksDBException e) {
         throw new FlinkRuntimeException("Error while updating data to RocksDB", e);
      }
   }
}

Issue Links

• links to: GitHub Pull Request #7421