[FLINK-11146] Get rid of legacy codes from ClusterClient

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.9.0
• Component/s: Command Line Client, Tests
• Labels: pull-request-available
• Assignee: Zili Chen
• Reporter: Zili Chen
• Created: 13/Dec/18 03:53
• Updated: 28/Mar/19 12:03
• Resolved: 28/Mar/19 12:03

Description

As StephanEwen mentioned in ML
https://lists.apache.org/thread.html/cc46fde6f8b31d4e833b01e5814a9547c8a67ea3e08a31ec5d71145e@%3Cdev.flink.apache.org%3E
, the client needs big refactoring / cleanup. It should use a proper HTTP client library to help with future authentication mechanisms.

After an investigation I notice that the valid cluster clients are only MiniClusterClient and RestClusterClient. Legacy clients, StandaloneClusterClient and YarnClusterClient, as well as pre-FLIP-6 codes inside ClusterClient, should be removed as part of FLINK-10392. With this removal we arrive a clean stage where we can think how to implement a proper HTTP client more comfortably.

1. StandaloneClusterClient is now depended on by LegacyStandaloneClusterDescriptor (the removal is tracked by FLINK-10700) and FlinkClient(part of flink-storm which is decided to be removed FLINK-10571). Also relevant tests need to be ported(or directly removed).

2. The removal of YarnClusterClient should go along with FLINK-11106 Remove legacy flink-yarn component.

3. Testing classes inheriting from ClusterClient need to be ported(or directly removed).

4. Get rid of legacy codes inside ClusterClient it self, such as #run(JobGraph, ClassLoader)

Besides, what is JobClient used for? I cannot find valid usages of it. (Till mentioned it at ML https://lists.apache.org/thread.html/ce99cba4a10b9dc40eb729d39910f315ae41d80ec74f09a356c73938@%3Cdev.flink.apache.org%3E)
cc mxm till.rohrmann

Issue Links

• is a child of: FLINK-10392 Remove legacy mode
• is a parent of: FLINK-11507 Remove invalid test JobClientActorTest
• is a parent of: FLINK-11508 Remove invalid test AkkaJobManagerRetrieverTest
• is a parent of: FLINK-11509 Remove invalid test ClientConnectionTest
• is a parent of: FLINK-11511 Remove legacy class JobAttachmentClientActor
• is a parent of: FLINK-11512 Port CliFrontendModifyTest
• is a parent of: FLINK-11513 Port CliFrontendSavepointTest
• is a parent of: FLINK-11514 Port ClusterClientTest
• is a parent of: FLINK-11515 Port ClientTest
• is a parent of: FLINK-11540 Remove StandaloneClusterClient
• is blocked by: FLINK-10700 Remove LegacyStandaloneClusterDescriptor
• is blocked by: FLINK-11106 Remove legacy flink-yarn component
• is blocked by: FLINK-10571 Remove support for topologies
• links to: GitHub Pull Request #7762