[FLINK-11142] Undefined behavior in the conversion from DataStream/DataSet to Table

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5.5, 1.6.2, 1.7.0
• Fix Version/s: 1.8.0
• Component/s: Table SQL / API
• Labels: pull-request-available
• Assignee: Hequn Cheng
• Reporter: Yangze Guo
• Created: 12/Dec/18 12:33
• Updated: 30/Nov/21 20:38
• Resolved: 27/Dec/18 02:40

Description

When we try to convert DataStream/DataSet to Table. There are two ways of adding schema information, ByName or ByPosition.

This feature first proposed in this pr.

In ByPosition mode, the current code does not check if the number of fields less than its in  DataStream/DataSet. This may cause undefined behavior, e.g. make a projection in ByPosition mode.

We can either fix it by adding some checking or regard this as a feature and just improve the doc to clarify it. In my opinion, the latter way seems better.

twalthr Could you take a look at it when you free?

Issue Links

• links to: GitHub Pull Request #7352