[FLINK-11102] Enable check for previous data in SpanningRecordSerializer

• Type: Improvement
• Status: Open
• Priority: Not a Priority
• Resolution: Unresolved
• Affects Version/s: 1.8.0
• Component/s: Runtime / Network
• Labels: auto-deprioritized-major auto-deprioritized-minor auto-unassigned
• Assignee: Unassigned
• Reporter: Nico Kruber
• Created: 07/Dec/18 13:26
• Updated: 26/Dec/21 10:39

Description

SpanningRecordSerializer only verifies that there is no left-over data from a previous serialization call if SpanningRecordSerializer#CHECKED is true but this is hard-coded as false. Now if there was previous data, we would silently drop this and continue with our data. The deserializer would probably notice and fail but identifying the root cause may not be as easy anymore.

-> We should enable that check by default since the only thing it does is to verify !java.nio.Buffer#hasRemaining() which cannot be too expensive.