[FLINK-10789] Some new serializer snapshots added after 1.6 are not implementing the new TypeSerializerSnapshot interface

• Type: Improvement
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 1.7.0
• Component/s: API / Type Serialization System
• Labels: pull-request-available
• Assignee: Tzu-Li (Gordon) Tai
• Reporter: Tzu-Li (Gordon) Tai
• Created: 05/Nov/18 09:08
• Updated: 11/Nov/18 04:37
• Resolved: 11/Nov/18 04:37

Description

In commit [3787b89105c6a005ddca999b0b8a0356e812ede6|https://github.com/apache/flink/commit/3787b89105c6a005ddca999b0b8a0356e812ede6,] there were a few serializer snapshot implementations that were newly added, namely:

• LockableSerializerConfigSnapshot
• ListViewSerializerConfigSnapshot
• MapViewSerializerConfigSnapshot
• ScalaEitherSerializerConfigSnapshot

The problem is that instead of implementing the newer TypeSerializerSnapshot, they are extending the legacy deprecated TypeSerializerConfigSnapshot. This doesn't break things, but we will be redundantly writing Java-serialized with the new snapshots, as well as causing us to must introduce migration paths code later on after releasing them.

It would be more ideal to implement them properly as TypeSerializerSnapshot for the release.

Issue Links

• links to: GitHub Pull Request #7028