Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-10613

Remove logger casts in HBaseConnectorITCase

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      During the testing of 1.5.5-rc1 an issue was discovered in the HBaseConnectorITCase where a cast could fail if flink-table tests were previously executed, since in this case the jcl-over-slf4j bridge is being loaded.

      Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=128m; support was removed in 8.0
      Running org.apache.flink.addons.hbase.HBaseConnectorITCase
      Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.557 sec <<< FAILURE! - in org.apache.flink.addons.hbase.HBaseConnectorITCase
      org.apache.flink.addons.hbase.HBaseConnectorITCase  Time elapsed: 0.556 sec  <<< ERROR!
      java.lang.ClassCastException: org.apache.commons.logging.impl.SLF4JLocationAwareLog cannot be cast to org.apache.commons.logging.impl.Log4JLogger
      
      org.apache.flink.addons.hbase.HBaseConnectorITCase  Time elapsed: 0.557 sec  <<< ERROR!
      java.lang.NullPointerException

      While the logger-loading issue itself is rather subtle I believe the underlying issue to be the casts to set the log-level.

      It should be possible to enable said logging through the log4j-test.properties configuration instead.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            chesnay Chesnay Schepler
            chesnay Chesnay Schepler
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment