[FLINK-10385] Implement a waitUntilCondition utils

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 1.7.0
• Component/s: Runtime / Coordination, Tests
• Assignee: Unassigned
• Reporter: Zili Chen
• Created: 21/Sep/18 04:39
• Updated: 18/Dec/20 11:19
• Resolved: 18/Dec/20 11:19

Description

Recently when I refine some tests, I notice that it is a common requirement to wait until a (stable) condition occur.

To achieve this, we have ExecutionGraphTestUtils#waitUntilJobStatus and many. Most of them can simply abstract as

public static void waitUntilCondition(SupplierWithException<Boolean, Throwable> conditionSupplier, Deadline deadline) {
  while (deadline.hasTimeLeft()) {
    if (conditionSupplier.get()) { return; }
    Thread.sleep(Math.min(deadline.toMillis(), 500);
  }
  throws new IlleagalStateException("...");
}

 

I propose to implement such a method to avoid too many utils method scattered to achieve the same purpose.
Looking forward to your advice. If there is previous code/project already implemented this, I am glad to introduce it.

cc Zentol

 

PS: the file attached is some code I found could satisfy this proposal.